Graceful handling of data from Redis that fails to be parsed

Open
#607 5 comments 0 reactions 1 assignee View on GitHub

@Al2Klimov is already working on this.

Since Jul 11, 2023.

Assessment

This issue has not been assessed yet.

Description

area/configsync area/history area/runtime area/statesync

At the moment, Icinga DB completely relies on Icinga 2 that there is no data present in Redis it can't process. If this assumption is violated, Icinga DB simply crashes at the moment. There already were a few instances where such bugs were reported, for example:

Not writing data that the receiver does not understand at all is a good idea, but in order to make Icinga DB more robust, we should implement more graceful/fine-grained error handling in Icinga DB as well.

Task

Go through all code that reads from Redis and the errors that can occur, especially where data is parsed. Check if there is a more graceful way of handling the error than just bailing out. For example, for the object sync, an individual object that fails to be parsed could just be skipped. Summarize your findings in a comment to this issue and propose changes where and how things could be handled better.

Dominant language
Go
Stars
76
Forks
23
Avg merge
13h 37m
Merged PRs (30d)
11

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Icinga/icingadb

All issues in Icinga/icingadb

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.