Icinga / Icinga/icinga2

Config: reject Downtimes w/ negative duration or end before start

Open
#9,776 0 comments 0 reactions 0 assignees View on GitHub

@Al2Klimov is already working on this.

Since May 25, 2023.

  • #9773 by @Al2Klimov — open
area/configuration core/quality
Dominant language
C++
Stars
2.2k
Forks
616
Avg merge
5d 6h
Merged PRs (30d)
10

Description

Describe the bug

Icinga 2 accepts the above w/o even complaining. Apart from

  • #9774

this is not an actual bug. It just doesn’t make sense.

Expected behavior

We should help the users, to catch such mistakes(?) ASAP.

At best Icinga 2 just enforces correct attributes like

  • #9773

but, in short, this could break existing Downtimes.

(I still think that we can vanish all the "perfectly working" fixed Downtimes w/ negative duration out there.)

Additional context

https://github.com/Icinga/icinga2/pull/9775#issuecomment-1568294931

To do

  • make a plan

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing this issue together with #9773, #9774, and the linked discussion in pull request #9775. The first milestone is a decided plan for handling negative durations and end times before starts, including compatibility with existing fixed downtimes; the issue does not name files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.