Icinga / Icinga/icinga2

Don't expose `Internal.run_with_activation_context`

Open
#9,450 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/configuration core/quality
Dominant language
C++
Stars
2.2k
Forks
616
Avg merge
5d 6h
Merged PRs (30d)
10

Description

Currently, Internal.run_with_activation_context is still available at runtime and can be (mis)used in user configuration. I can't imagine a valid use case for this function there and its use would most likely result in an inconsistent state anyways (newly created objects that aren't properly synced/started).

For most members of Internal, Internal.remove("MemberName") is done at some point. The same could also be done for run_with_activation_context. However, we should also check if exposing this function to the DSL is even needed in the first place, or if we could just load the early config that uses this function in an activation context by default.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Internal.run_with_activation_context and the existing Internal.remove patterns. Then inspect how early configuration is loaded and whether it already runs in an activation context. Done means reaching a decision on whether to remove the exposed function or change early configuration loading, with the issue's runtime exposure concern addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.