InfluxdbWriter chokes on perfdata "U"
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 616
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 10
Description
Describe the bug
I am getting a lot of warnings in my icinga2 logs like this:
warning/InfluxdbWriter: Ignoring invalid perfdata for checkable 'dev-bas1-pos-v01.sf-rz.de!postgres_patroni_dev_01_tst_longest_query' and command 'check_pgactivity' with value: 'testdb max'=Us;60;90
Looking at https://nagios-plugins.org/doc/guidelines.html#AEN200, the value "U" is perfectly legitimate here
To Reproduce
- set up a check which will return "U" as value in the performancedata (check_pgactivity works fine with the longest_query)
- run the check and look into the logs
Expected behavior
I would love to turn off those warnings in the icinga logs (only for value U) or have InfluxWriter insert something like null instead of failing/complaining.
Your Environment
Include as many relevant details about the environment you experienced the problem in
- Version used (
icinga2 --version): 2.13.2-1 - Operating System and version: RHEL 7.9
- Enabled features (
icinga2 feature list): api checker ido-pgsql influxdb mainlog notification
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the InfluxdbWriter handling of performance data and reproduce the warning with a check_pgactivity result containing the value "U". Verify the behavior through the icinga2 logs and confirm that this valid value no longer produces a warning or is represented as null in InfluxDB.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100