Icinga / Icinga/icinga2

Icinga DB: Include object names in runtime deletion events

Open
#10,896 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
2.2k
Forks
616
Avg merge
5d 6h
Merged PRs (30d)
10

Description

Is your feature request related to a problem? Please describe.

Icinga 2 currently sends only the respective object IDs when sending runtime deletion events, which was fine till now, since Icinga DB only needed that hash ID to delete the respective objects from the database. However, since Icinga DB (Go) will now be used as Icinga Notifications source as well, the ID alone isn't enough to construct the respective object that can be used to close the corresponding incident in Icinga Notifications. For that to work, we would've to either always pre-select the objects from the database before they're completely removed (before performing the respective delete queries) or Icinga 2 includes the respective object name in the deletion event. Since patching Icinga 2 wouldn't require a hard dependency on the Icinga DB (Go) side, @nilmerg prefers the latter option, thus I'm opening this issue for it here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating where Icinga 2 emits runtime deletion events and inspect the existing payload that contains only object IDs. Update the event data so the respective object name is included, then verify that deletion events provide enough information for Icinga Notifications to close incidents without pre-selecting deleted objects.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend, distributed-systems
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.