Icinga / Icinga/icinga2

doc/win-dev.ps1: demand rebooting after installing Chocolatey

Open
#10,475 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/windows good first issue
Dominant language
C++
Stars
2.2k
Forks
616
Avg merge
5d 6h
Merged PRs (30d)
10

Description

To Reproduce

Follow instructions under https://github.com/Icinga/icinga2/blob/v2.14.6/doc/21-development.md#tldr.

Describe the bug

As expected, Chocolatey gets installed

https://github.com/Icinga/icinga2/blob/b27310fb6cc6af56433f52543d146b8186f9d99d/doc/win-dev.ps1#L63-L70

and it even tells you

Chocolatey CLI (choco.exe) is nearly ready.
You need to restart this machine prior to using choco.

which gets lost in a haystack of debug output. doc/win-dev.ps1 then runs choco install ... which fails with: ".NET 4.8 is not installed or may need a reboot to complete installation. Please install .NET Framework 4.8 manually and reboot the system."

Expected behavior

After

https://github.com/Icinga/icinga2/blob/b27310fb6cc6af56433f52543d146b8186f9d99d/doc/win-dev.ps1#L63-L70

an error is thrown telling the user to reboot and re-run the script.

Your Environment

  • Operating System and version: Windows 10 (NWS OpenStack, no updates applied)

Additional context

I was just testing #9747. 🙈

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in doc/win-dev.ps1 at lines 63-70, following the development setup instructions linked in the issue. Reproduce Chocolatey installation on Windows 10 and observe how the subsequent choco install command behaves. Done means the script clearly reports that a reboot is required and stops so the user can rerun it afterward.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.