Use CMake unity builds instead of custom implementation
Open
Nobody has claimed this yet.
core/quality
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 616
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 10
Description
CMake supports unity builds starting with version 3.16: https://cmake.org/cmake/help/latest/prop_tgt/UNITY_BUILD.html
Looking at #10402, it should be possible to require that version and remove our custom implementation for it: https://github.com/Icinga/icinga2/tree/master/tools/mkunity
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the custom unity-build implementation under tools/mkunity and the related changes in issue #10402. Check how the project currently configures unity builds, then compare it with CMake's UNITY_BUILD support introduced in version 3.16. Done means requiring the supported CMake version and removing the custom implementation without breaking the build.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100