Icinga / Icinga/icinga-powershell-plugins

Enhancement for Invoke-IcingaCheckNetworkInterface error and discard checks

Open
#406 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PowerShell
Stars
55
Forks
30
PR merge metrics
No merged PRs in 30d

Description

In my opinion the currently implemented checks for interface discards and errors are suboptimal at least when it comes to percentage thresholds which for me is the only useful threshold „unit“. In a network it is not unusual to have a few errors and discards. What really matters is if there are too much of them in propotion to the overall packets (= percent).
The problem with the current implementation is that the corresponding windows performance counters are incrementing values.
Let‘s say I have 100.00 received packets during a sample interval and 10 discards which means 0,01% discards.
Now let‘s say within the next sampling interval I receive 10 packets and 0 discards. But the check will show 100% discards because the incrementing windows discard counter is still 10.
So in my opinion it would make more sense to use a delta value for discards and errors for the percentage calculation.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Invoke-IcingaCheckNetworkInterface and the handling of Windows performance counters for interface errors and discards. Reproduce successive sampling intervals with incrementing counters, then verify that percentage thresholds use interval deltas and remain meaningful when packet counts change.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
networking, observability-sre
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.