Icinga / Icinga/icinga-powershell-plugins
Invoke-IcingaCheckUpdates: Output is confusing
Nobody has claimed this yet.
- Dominant language
- PowerShell
- Stars
- 55
- Forks
- 30
- PR merge metrics
- No merged PRs in 30d
Description
Hello :)
I updated the plugins to v1.10.1 recently and find the short message output of the plugin a bit confusing.
The output "Windows Updates: 6 OK" leads me to think that there are 6 updates available for this machine, and that that is "OK".
Though by now I figured out that the "6" refers to the 6 categories (summary, reboot, other, security, defender, rollups) I would still not suggest this output.
And (imo) it gets worse/more confusing with threshold breaches
Suggestion: Don't display any numbers in the short message. Or add something like "category".
OK: [OK] Windows Updates below thresholds
CRITICAL/WARNING: [CRITICAL/WARNING] Windows Update Categories: 2 CRITICAL, 1 Warning, 5 OK (comma-separation)
Also I would suggest omitting the c unit in the text output.
Best
log1c
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Invoke-IcingaCheckUpdates entry point and the code that builds its short message and unit text. Reproduce the examples from the issue, then update the output so category counts and threshold status are unambiguous and the c unit is omitted; done when the resulting messages match the stated suggestions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- powershell
- Domain
- observability-sre
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100