Icinga / Icinga/icinga-php-thirdparty

[action required] Demand checking ‎THIRD_PARTY_LICENSES.md‎ on every (dependabot) PR

Open
#112 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
7
Forks
4
Avg merge
4h 55m
Merged PRs (30d)
6

Description

Even if everyone who reviews (dependabot, but not only) PRs here printed a checklist and pinned it on the own wall/cabinet, it won't reliably prevent oversight of THIRD_PARTY_LICENSES.md‎. I have seen such an overseen physical list myself recently, ask me in person if you're interested in the story.

The only reliable way I see to keep THIRD_PARTY_LICENSES.md‎ up to date (and this will be necessary, see e.g https://github.com/Icinga/icinga2/pull/9675) is a GitHub action which leaves a comment on every newly opened PR here telling devs to check THIRD_PARTY_LICENSES.md‎. (https://github.com/Icinga/icinga-php-thirdparty/pull/110#discussion_r2980781078)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking the repository's existing GitHub Actions workflow files and read THIRD_PARTY_LICENSES.md to understand the required reminder. Add a workflow that comments on every newly opened pull request, including Dependabot PRs, and verify that the comment directs reviewers to check THIRD_PARTY_LICENSES.md.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.