IanLunn / IanLunn/Sequence

Sequence with svg in Edge

Open
#280 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.3k
Forks
470
PR merge metrics
No merged PRs in 30d

Description

Hi,

I've got some errors in a test sequence with svg in it when viewed in Edge.

The error is in resetInheritedSpeed function at line 1962 in sequence.js

I've changed : el.style[Modernizr.prefixed("transition")] = "0ms 0ms";
to : if (el.style) el.style[Modernizr.prefixed("transition")] = "0ms 0ms";

idem at line 2002

I think it's because on Edge a path node in a svg for example has no .style property ?
Surely there is a problem with svg with elements return by var stepElements = self.$steps[step - 1].querySelectorAll("*") (at line 1973) because errors appears.

Thanks.
Florent

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.