IanLunn / IanLunn/Sequence

phaseEnded/stepEnded don't occur when navigation is skipped and fadeStepWhenSkipped is disabled

Open
#265 0 comments 0 reactions 0 assignees View on GitHub
General Improvements
Dominant language
JavaScript
Stars
3.3k
Forks
470
PR merge metrics
No merged PRs in 30d

Description

**Dependencies**: `navigationSkip: true`, `fadeStepWhenSkipped: false`, `preventReverseSkipping: false`

**Problem**: With the above dependencies, when the user navigates between steps quickly, the `phaseEnded()` and `stepEnded()` do not occur until navigation skipping has stopped. This may cause issues for themes that change the states/styles of steps based on these public events. For example, when a step ends, it's background colour is changed. Without these events, the background won't be able to change when navigation skipping occurs.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.