ITensor / ITensor/ITensorNetworks.jl

[ENHANCEMENT] Make `expect` vertices input consistent

Open
#306 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Julia
Stars
128
Forks
23
Avg merge
4d 7h
Merged PRs (30d)
7

Description

Some versions of expect take vertices as arguments and some take them as keyword arguments, we should make that consistent. See this discussion: https://github.com/ITensor/ITensorNetworks.jl/pull/300#discussion_r2875216369

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the expect implementations and the discussion linked in the issue, especially the referenced pull request discussion. Identify the argument style that should be consistent across versions, then verify that every expect variant follows it and that the relevant existing tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend-api-design
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.