ITensor / ITensor/ITensorNetworks.jl

Allow `using ITensorNetworks: add!`

Open
#210 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
128
Forks
23
Avg merge
4d 7h
Merged PRs (30d)
7

Description

Since https://github.com/ITensor/ITensors.jl/pull/1551 and https://github.com/ITensor/ITensorMPS.jl/pull/31, ITensors.jl no longer exports add!, since it is primarily an operation for OpSum, which was also removed as an export.

As an alternative, one has to load ITensorMPS.jl which exports add!. However, we don't want to force users of ITensorNetworks.jl to explicitly load ITensorMPS.jl, so we should allow users to do using ITensorNetworks: add! to access it, and also considering exporting it eventually (I'm trying to limit exports from ITensorNetworks.jl for the time being).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating how ITensorNetworks.jl defines its public exports and how it accesses the add! operation from its dependencies. Verify the package can provide add! through an explicit using ITensorNetworks: add! without requiring ITensorMPS.jl, and add or update coverage for that import behavior if the repository has relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend-api-design
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.