ITensor / ITensor/ITensorNetworks.jl

Filling missing keyword arguments for sweeps

Open
#150 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
128
Forks
23
Avg merge
4d 7h
Merged PRs (30d)
7

Description

In #143, expand was introduced to pad keyword arguments to the length of the number of sweeps by repeating the last value, for example maxdim=[10, 20] gets expanded to maxdim=[10, 20, 20, 20] if nsweeps=4.

Keyword arguments are treated as nested table-like objects, inspired by the perspective of Tables.jl where a NamedTuple with values that are vectors of a common length can be interpreted as a table where the vectors are named columns of a table.

It could be nice to formalize that perspective a little bit more and turn that concept into a subpackage and see how it connects to other functionality in the Julia Tables/DataFrames ecosystem.

One thing I came across is that what we called expand in #143 can be viewed as a certain technique for filling in missing data in data sets (say from clinical trials) called last observation carried forward (LOCF), which is implemented as an operation on DataFrames in Impute.locf.

I thought that was an interesting perspective and connection to keep in mind, possibly for generalizing or formalizing our keyword argument processing code or choosing a name for that operation that aligns with known operations in data processing.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the expand behavior introduced in issue #143 and locate the current keyword-argument processing entry point. Compare its treatment of nested table-like values with the Tables.jl and Impute.locf perspectives mentioned here. Done would require an agreed scope and name for a generalized or formalized operation, along with corresponding implementation and tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.