ITensor / ITensor/ITensorMPS.jl
Issue in mps.jl file, line 899
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 85
- Forks
- 27
- Avg merge
- 22m
- Merged PRs (30d)
- 1
Description
I encountered an issue in the mps.jl file on line 899, where the code reads:
Li21 *= prime(dag(si[pL21]), !sᵢ)
It appears that the variable si is used, but based on the context, I believe it should actually be psi. This leads to problems when calling the correlation_matrix function with different operators and assigning specific sites.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in mps.jl at line 899 and trace how correlation_matrix handles different operators and assigned sites. Check whether si or psi is the intended variable in that context, then verify the corrected behavior by exercising correlation_matrix with those cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100