ITensor / ITensor/DataGraphs.jl
Remove `underlying_graph` from the `AbstractDataGraph` interface.
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 13
- Forks
- 4
- Avg merge
- 5d 13h
- Merged PRs (30d)
- 2
Description
An AbstractDataGraph should implement the AbstractNamedGraph and AbstractDataGraph interface.
- Rename
IsUnderlyingGraphtrait to something more informative. e.g.IsDatafullGraph(name tbd) - An
AbstractNamedGraphshould be assumed to not have data by default (https://github.com/ITensor/DataGraphs.jl/pull/94#discussion_r3117632795) - Add function
dataless_graphto construct a similar graph, but without data. - Consider if it is worth removing
underlying_graphfrom the concreteDataGraph.
Related: https://github.com/ITensor/DataGraphs.jl/issues/102
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the AbstractDataGraph, AbstractNamedGraph, IsUnderlyingGraph, and DataGraph interfaces, then review related issue #102 and the linked discussion in pull request #94. Define the replacement trait name, the default data behavior, dataless_graph construction, and whether underlying_graph should be removed before considering the work complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100