ITensor / ITensor/BlockSparseArrays.jl

[BUG] Investigate potential compilation issues related to overloading `Base.cat`

Open
#34 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Julia
Stars
3
Forks
3
Avg merge
14m
Merged PRs (30d)
3

Description

@amilsted reported that as of this PR to NDTensors.BlockSparseArrays: https://github.com/ITensor/ITensors.jl/pull/1579 loading NDTensors.jl/ITensors.jl along with DifferentialEquations.jl causes huge compile times. That might also be related to https://itensor.discourse.group/t/linearmaps-and-itensors-incompatibility/2216.

For NDTensors.jl/ITensors.jl, that issue should get fixed by https://github.com/ITensor/ITensors.jl/pull/1601, since that PR removes BlockSparseArrays.jl from NDTensors.jl in favor of the version in this repository. We need to check if this package has the same problem, and if so rewrite it to avoid that problem.

See also https://github.com/ITensor/SparseArraysBase.jl/issues/25.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting this package's overloads of Base.cat and reproducing the reported compilation behavior when loading BlockSparseArrays.jl with DifferentialEquations.jl. Compare the relevant changes in ITensors.jl PRs 1579 and 1601 and SparseArraysBase.jl issue 25. Done means confirming whether the problem occurs here and rewriting the package if needed to avoid it.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.