ISISNeutronMuon / ISISNeutronMuon/MDMC

trajectories do not contain velocities

Open
#819 0 comments 0 reactions 0 assignees Claimed by @iermi View on GitHub
bug P3
Dominant language
Python
Stars
4
Forks
0
Avg merge
2d 4h
Merged PRs (30d)
5

Description

MDMC `Trajectory` object that is created as part of any MD simulation has zero velocities for all atoms. I suspect it is caused by this line:
https://github.com/MDMCproject/MDMCv0.2_pilot/blob/5ce5ada5a277d3fae846a87786e87d73160c7a6a/MDMC/MD/engine_facades/lammps_engine.py#L483
because it is not actually asking for LAMMPS to dump the velocities, such that when MDMC later converts the trajectory to a `Trajectory` object the velocities are automatically zero:
https://github.com/MDMCproject/MDMCv0.2_pilot/blob/5ce5ada5a277d3fae846a87786e87d73160c7a6a/MDMC/MD/engine_facades/lammps_engine.py#L644
and
https://github.com/MDMCproject/MDMCv0.2_pilot/blob/5ce5ada5a277d3fae846a87786e87d73160c7a6a/MDMC/MD/engine_facades/lammps_engine.py#L576

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.