ISISNeutronMuon / ISISNeutronMuon/MDMC
Use of OMP_NUM_THREADS is unclear/misleading
- Dominant language
- Python
- Stars
- 4
- Forks
- 0
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 5
Description
**Description of the error**
MDMC uses OMP_NUM_THREADS to set the number of cores for the parallel fqt calculations.
https://github.com/MDMCproject/MDMCv0.2_pilot/blob/4f8d11e03df758baf39477b6781e9f54835d879e/MDMC/trajectory_analysis/observables/concurrency_tools.py#L11-L25
https://github.com/MDMCproject/MDMCv0.2_pilot/blob/4f8d11e03df758baf39477b6781e9f54835d879e/MDMC/trajectory_analysis/observables/fqt.py#L469-L483
https://github.com/MDMCproject/MDMCv0.2_pilot/blob/4f8d11e03df758baf39477b6781e9f54835d879e/MDMC/trajectory_analysis/observables/fqt.py#L666-L688
Its misleading to use it in this way since OMP_NUM_THREADS should define the number of threads used by OpenMP not MDMC.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.