ISISNeutronMuon / ISISNeutronMuon/MDMC

Add error checking to LAMMPS kspace solver setting

Open
#145 0 comments 0 reactions 0 assignees View on GitHub
enhancement P1
Dominant language
Python
Stars
4
Forks
0
Avg merge
2d 4h
Merged PRs (30d)
5

Description

**Is your feature request related to a problem? Please describe.**
When LAMMPS throws errors with the Python interface, it always results in a fatal error. To minimise the frequency of this happening, it is preferable to prevent these errors from happening by preventing simulations setups which will result in errors being submitted to LAMMPS. One example of this is if a kspace_style should have been declared for the pair_style (e.g. for a long pair_style) but has been omitted.

**Describe the solution you'd like**
If LAMMPSEngine._set_space_solver does not set a kspace solver, determine if the pair_styles that have been set require one. If they do then raise an error.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.