ISISNeutronMuon / ISISNeutronMuon/MDMC

Implement Listener pattern for Interaction updates

Open
#133 1 comment 0 reactions 0 assignees View on GitHub
needs more info P1 refactor
Dominant language
Python
Stars
4
Forks
0
Avg merge
2d 4h
Merged PRs (30d)
5

Description

Interactions update their universe based on the universe of the atoms to which they apply. Currently this is simply done within the universe setter of each Atom, so it occurs every time one of the atoms in interaction.atoms is added to a universe.

As all atoms on which one interaction acts should belong to the same universe, this update only needs to occur when the first atom is added to the universe. To do this *implement the Listener pattern for Atoms and Interactions, and then after the interaction has a universe, remove the listener from the interaction.*

A Listener pattern also needs to be implemented for atom_type for Coulombic Interactions that have been initialised with atoms.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.