ISISNeutronMuon / ISISNeutronMuon/MDANSE

[BUG] Partial charges input field cannot hold the entire JSON string

Open
#877 0 comments 0 reactions 0 assignees View on GitHub
bug GUI
Dominant language
Python
Stars
29
Forks
8
Avg merge
2d 12h
Merged PRs (30d)
9

Description

**Description of the error**
For trajectories with enough atoms, it will become impossible to set the charges in the GUI, as the JSON string becomes truncated.

Here I had 4000 atoms in the trajectory, but I could only set the charges for 2583 of them.

**Describe the expected result**
It should be possible to set the partial charges for any number of atoms.

**Describe the actual result**

Image
The helper widget (above) shows all the charges to be set.
The actual input in the main widget ends suddenly:
Image

**Suggested fix**
Temporarily, we could relax the limits on the maximum string length in the main widget's QLineEdit.

In the long run, it would also be good to switch to a more compact way of writing the charges.

**Additional details**
N/A

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the main widget's partial-charges QLineEdit and reproduce the truncation with a trajectory containing many atoms. Ensure the input can hold the complete JSON string shown by the helper widget, then verify that charges for all atoms can be set without truncation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.