ISISNeutronMuon / ISISNeutronMuon/MDANSE

[ENHANCEMENT] Q-Vectors rework

Open
#705 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
29
Forks
8
Avg merge
2d 12h
Merged PRs (30d)
9

Description

**Is your feature request related to a problem? Please describe.**
Q-Vectors are currently somewhat limited in scope apparently to $\|Q\|$ calculations using a class hierarchy.

These generators will need to have the capacity to be passed various arguments as needed.

**Describe the solution you'd like**
The proposal is to rework the Q-vector generation system as actual generators to allow infinite and finite Q-Vector generators with paths (#446), explicit values (#458), $\|Q\|$ functionality.

Current Q Vector generators

- ApproximateDispersionQVectors.py
- CircularQVectors.py
- GridQVectors.py
- LatticeQVectors.py
- LinearQVectors.py
- SphericalLatticeQVectors.py
- CircularLatticeQVectors.py
- DispersionLatticeQVectors.py
- IQVectors.py
- LinearLatticeQVectors.py
- MillerIndicesQVectors.py
- SphericalQVectors.py

Proposed New Q Vector generators

- Q-vectors from generator function
- Q-vectors from list/array
- Q-vectors from paths

**Describe alternatives you've considered**
N/A

**Additional context**
N/A

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.