ISISComputingGroup / ISISComputingGroup/lewis
StreamHandler shouldn't inherit from asynchat.async_chat
Open
- Dominant language
- Python
- Stars
- 24
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Description
Makes testing a pain as need to be patched out.
Better to wrap an instance of async_chat and call methods on that.
An instance can probably be passed in through the constructor of StreamHandler and this means we can use a test double rather than using "patch".
Contributor guide
Assessment
This issue has not been assessed yet.