ISISComputingGroup / ISISComputingGroup/lewis

StreamHandler shouldn't inherit from asynchat.async_chat

Open
#306 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
24
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Makes testing a pain as need to be patched out.
Better to wrap an instance of async_chat and call methods on that.
An instance can probably be passed in through the constructor of StreamHandler and this means we can use a test double rather than using "patch".

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.