ISISComputingGroup / ISISComputingGroup/IBEX

Muons: Tpar editor (nice to have) improvements

Open
#8,991 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

# Issue Description

As a muon scientist I would like to make it even harder for my users to muck up the TPar file.

### How & Where?
This follows on from #8990 and covers the nice to have elements of what was requested by the muon group.

### Additional Information

- The format of the TPar file is constant, though the number of lines varies
- There are two TPar files used the regular one and the booster one
- The set temperature script and possibly script generator consume the tpar file
- There is currently a tpar editor as a device screen in the GUI
- Not every instrument wants to expose tpar editing to it's users
- A valid TPar file:
- containers a header. This is never changed
- Has a constant number of columns
- THigh is the TLow of the next line
- has at least one line that is not header

See our [Git Workflow](https://isiscomputinggroup.github.io/ibex_developers_manual/processes/git_and_github/Git-workflow.html).

# Acceptance Criteria
- [ ] We validate TPAR files edited in the editor (see above) before allowing them to be saved
- [ ] We present the data in the editor as a table for editing, rather than a text file

# How to Review
Before making a PR...
- _Provide verbose instructions for the reviewer to test that your changes work and fix the issue_
- _Describe if/how you have implemented testing for this issue_
- _Provide screenshots of the feature to help the reviewer if relevant_

_If not applicable, write "Not applicable"_

[comment]: <> (FILL IN BELOW)
> ...

**To the reviewer: Make sure to [update submodules](https://isiscomputinggroup.github.io/ibex_developers_manual/processes/git_and_github/Git-workflow.html)!**

Contributor guide

No contributing guide indexed for this repository

Research direction

Read the related issue #8990 and inspect the existing TPar editor device screen in the GUI. Trace how the set temperature script and possibly the script generator consume the regular and booster TPar files. Done means edited data is presented in a table and invalid files cannot be saved.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.