ISISComputingGroup / ISISComputingGroup/IBEX

JAWS: expose stop due to the minimum gap being reached to users

Open
#8,915 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

# Feature Description
As a use/instrument scientist I would like it to be clear when my jaws/slits/barn doors have[ stopped moving because a min gap has been reached](https://github.com/ISISComputingGroup/IBEX/issues/8505).

## Explanation
When a jaw blade is moving and the gap with the other in the pair reaches a minimum value, a stop command is issues. This stop command is not visible to the user. A recent patch [LINK here @Tom-Willemsen] has added a line to the log, but this will only be seen if the user/scientist goes looking and it should be made more apparent to them before they have to go for a logs. This should be apparent both when setting jaw positions in the GUI and with scripts.

### Additional Information

See our [Git Workflow](https://isiscomputinggroup.github.io/ibex_developers_manual/processes/git_and_github/Git-workflow.html).

# Acceptance Criteria

- [ ] When a user sets the positions of jaws in the GUI and the min gap is hit, some message visible to them
- [ ] When a user sets the positions of jaws in a script and the min gap is hit, some message is visible to them

# How to Review
Before making a PR...
- _Provide verbose instructions for the reviewer to test your changes_
- _Describe how you have implemented testing for this feature_
- _Provide screenshots of the feature to help the reviewer if relevant_

_If not applicable, write "Not applicable"_

[comment]: <> (FILL IN BELOW)
> ...

**To the reviewer: Make sure to [update submodules](https://isiscomputinggroup.github.io/ibex_developers_manual/processes/git_and_github/Git-workflow.html)!**

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.