ISISComputingGroup / ISISComputingGroup/IBEX

Make a central `PVValue` definition

Open
#8,913 2 comments 0 reactions 0 assignees View on GitHub
Friday
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

# Feature Description

As a developer, I would like to be able to import `PVValue` from a central location anywhere in the project without needing to import Genie Python.

## Explanation
Genie python is a large import, and so in some cases it has been avoided to import when just the `PVValue` type is required, this has lead to multiple definitions of `PVValue` in the project, these should be removed and replaced with a central definition in `ibex-non-ca-helpers` so that if needed the type can be modified in a single location, and code duplication is avoided.

### Additional Information
As well as the changes in genie python and other locations where PVValue is defined, all imports of PVValue will need to be pointed at the new location.

# Acceptance Criteria
- [ ] `PVValue` is defined in a central location where it can easily be imported for all uses.
- [ ] All current definitions of `PVValue` and imports of them are replaced with an import of this central definition.

# How to Review
Before making a PR...
- _Provide verbose instructions for the reviewer to test your changes_
- _Describe how you have implemented testing for this feature_
- _Provide screenshots of the feature to help the reviewer if relevant_

_If not applicable, write "Not applicable"_

[comment]: <> (FILL IN BELOW)
> ...

**To the reviewer: Make sure to [update submodules](https://isiscomputinggroup.github.io/ibex_developers_manual/processes/git_and_github/Git-workflow.html)!**

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.