ISISComputingGroup / ISISComputingGroup/IBEX
Knauer Valve Driver: Allow use of Valve Unifier 4.1 Command Protocol
- Dominant language
- No language data
- Stars
- 6
- Forks
- 2
- Avg merge
- 16h 40m
- Merged PRs (30d)
- 2
Description
# Feature Description
As someone using a Kanuer valve system I want to be able to keep using the newer models, which are ethernet connected and use a different command protocol.
## Explanation
These valve drivers are used to feed different substances through to different places.
### Additional Information
- There is a manual in the usual location
- It should be possible to extend the existing driver to allow an ethernet connection instead, and load an appropriate db with an appropriate protocol file to allow communication without making those doing set up to do anything more than tell it which comms method to use
- The following functions and new commands should be added:
- Report on and set the remote state (`REMOTE?`, `REMOTE`, and `LOCAL` commands)
- Check on the status of the device (`STATUS?` command)
- Set and read the position (`POSITION` command)
- Check for errors and reset the error state (`ERROR?` and `RESET_ERROR` command)
- Note that there are commands available in relation to programs and more, this is not being detailed here as at present these are not used
# Acceptance Criteria
- [ ] The Emulator is extended to have the new commands available
- [ ] The tests are extended to ensure that both the older and newer commands function as expected
- [ ] The comms methods are extended to cover Ethernet as well as RS232
- [ ] The new commands are made available via appropiate protocol and db files when the IOC is built
# How to Review
Before making a PR...
- _Provide verbose instructions for the reviewer to test your changes_
- _Describe how you have implemented testing for this feature_
- _Provide screenshots of the feature to help the reviewer if relevant_
_If not applicable, write "Not applicable"_
[comment]: <> (FILL IN BELOW)
> ...
**To the reviewer: Make sure to [update submodules](https://isiscomputinggroup.github.io/ibex_developers_manual/processes/git_and_github/Git-workflow.html)!**
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.