ISISComputingGroup / ISISComputingGroup/IBEX

HIFIMAGS: allow setting persistent flag in all field modes

Open
#8,640 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

# Feature Description

As an inst. sci. on HIFI I would like to be able to set the HIFIMAGS persistent mode flag in all field modes.

## Explanation

> [...] as the button is only setting a flag to be acted on the next time the main magnetic field is set, I can’t see the harm in allowing setting it any time. In particular it would speed up going from low field mode (with the main magnet persistent at zero for better stability) to high field non persistent: changing mode re-sends zeros to many supplies and that would mean warming and re-cooling the switch before warming it again to set the LF value wanted for the next run.

# Acceptance Criteria

- Persistent mode flag settable regardless of current field mode
- Consequences of this explicitly discussed and understood with scientists

# How to Review
Before making a PR...
- _Provide verbose instructions for the reviewer to test your changes_
- _Describe how you have implemented testing for this feature_
- _Provide screenshots of the feature to help the reviewer if relevant_

_If not applicable, write "Not applicable"_

[comment]: <> (FILL IN BELOW)
> ...

**To the reviewer: Make sure to [update submodules](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Git-workflow#reviewing-work-for-the-submodules-of-epics)!**

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.