ISISComputingGroup / ISISComputingGroup/IBEX
Beckhoff/TwinCAT: Update our fork of adsDriver
- Dominant language
- No language data
- Stars
- 6
- Forks
- 2
- Avg merge
- 16h 40m
- Merged PRs (30d)
- 2
Description
https://github.com/Cosylab/adsDriver has been updated recently and I'd like to test out the changes and then utilise them.
currently we do https://github.com/ISISComputingGroup/EPICS-motorExtensions/blob/master/beckhoffApp/Db/single_axis_tc.substitutions#L41-L42 to get the current SP velocities which we then forward on to the motor record in https://github.com/ISISComputingGroup/EPICS-ioc/blob/master/TC/TC-IOC-01App/Db/axis_monitors.db#L26-L41
It looks like asyn:readback has now been added to adsDriver so we probably don't need to explicitly read back these two velocities, and rather just forward them directly to .VELO and .JVEL of the motor record.
### acceptance criteria
- [ ] our fork of adsDriver is updated with the new commits upstream
- [ ] these changes are "smoke tested" ideally on a real beckhoff but simulated will also work
- [ ] the two velo RBV pvs are removed in favour of asyn:readback on the write pv template, if this works OK.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.