ISISComputingGroup / ISISComputingGroup/IBEX

Danfysik 9000s: Display of interlocks in GUI

Open
#8,503 0 comments 0 reactions 0 assignees View on GitHub
2
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

# Issue Description

As a user of IBEX I have found the Danfysik 9000 series interlocks are displayed incorrectly in the IBEX GUI - the wrong interlock is highlighted compared to what the instrument is reporting.

### How & Where?
- _How did the issue come about/known cause of issue if any?_
- _Where is the issue likely to be (be as specific as possible e.g. filepaths)_

It was reported to me and @Tom-Willemsen by RH and TS of the power supplies group that whilst the 8000 series power supplies have their interlock status displayed correctly within the IBEX GUI, the 9000 series do not light up the correct LEDs when interlocks are tripped. They suggested it may be the functionality was straight copied from the 8000 series, but the 9000 behaves differently.

### Reproducible (Yes/No)?

If yes, describe step-by-step how to reproduce the issue.

[comment]: <> (FILL IN BELOW)
> ...

### Additional Information

What else do I need to know before starting?

- _Where required files/links are_
- _Describe any potential difficulties with this ticket_
- _Provide links to tickets that must be completed before starting_
- _Provide any images that would be relevant to the ticket_

_If not applicable, write "Not applicable"_

[comment]: <> (FILL IN BELOW)
> ...

See our [Git Workflow](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Git-workflow#development-work).

# Acceptance Criteria
What is the acceptance criteria of this ticket? What should the reviewer expect to be complete?
- _Define specific conditions that must be met for the issue to be considered complete_
- _Use bullet points for clarity_
- _Ensure each criterion is unique, testable and verifiable_

[comment]: <> (FILL IN BELOW)
> ...

# How to Review
Before making a PR...
- _Provide verbose instructions for the reviewer to test that your changes work and fix the issue_
- _Describe if/how you have implemented testing for this issue_
- _Provide screenshots of the feature to help the reviewer if relevant_

_If not applicable, write "Not applicable"_

[comment]: <> (FILL IN BELOW)
> ...

**To the reviewer: Make sure to [update submodules](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Git-workflow#reviewing-work-for-the-submodules-of-epics)!**

planning 37:47 2024/10/31

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.