ISISComputingGroup / ISISComputingGroup/IBEX

IOCTestingFramework: Make skip if recsim / devsim more robust

Open
#8,436 0 comments 0 reactions 0 assignees View on GitHub
training
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

## The following is incorrect but doesn't provide an error
```Python
@skip_if_recsim
def test_GIVEN_tempA_on_device_X_THEN_ioc_reports_X(self):
self.fail("test")
```
This will pass the test without checking in both RECSIM & DEVSIM .
## Correct syntax
```Python
@skip_if_recsim("reason for skipping test")
def test_GIVEN_tempA_on_device_X_THEN_ioc_reports_X(self):
self.fail("test")
```

## Acceptance criteria
- [ ] If someone uses the decorator without providing a reason then an error should be thrown.

## How to Test
_verbose instructions for reviewer to test changes
(**Add before making a PR**)_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.