ISISComputingGroup / ISISComputingGroup/IBEX

Beckhoff: do not fill logs when PLC is disconnected

Open
#8,406 1 comment 0 reactions 0 assignees Claimed by @esmith1729 View on GitHub
5 rework
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

As a developer I would like the TC IOC to not log as much when the error message is the same. disk space usage was improved with #7618 but I would like adsDriver to be more clever about sum read failures etc. when it cannot read a variable suddenly (this may be the case of a beckhoff which suddenly fails to communicate, but not on startup)

### acceptance criteria
- [ ] AdsDriver is modified to recognise when it is printing the same error lots of times and just truncates the messages by saying something like "this error happened x times" on an interval

note we already do this somewhere i think? or perhaps it's an option in asyn. might be worth doing some research to see existing solutions.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.