ISISComputingGroup / ISISComputingGroup/IBEX

Moxa ioLogik: Move existing instances to using the AI/DI channel names

Open
#7,964 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

As someone using the Moxa ioLogik devices, I would rather have a single naming convention, with the introduction of the 1242 which has both analogue and digital values, both of which start as channel 0 the existing names are no longer ideal. As part of #7875 new AI and DI names were created which should be used instead.

### Acceptance Criteria
- [ ] A list of all existing uses of the ioLogiks is created
- [ ] A ticket is created to update each of those to use the new name structure
- [ ] The st.cmds for each device type passes an appropriate CHANPREFIX macro to st-aliases.cmd
- [ ] The existing chan names are removed from the config.xml, and the descriptions updated appropriately

### Notes
- It is possible to do this on each instrument after a release containing 7875 has been deployed to an instrument by duplicating existing names into the appropriate matched value in the AI/DI chan lists, the macro can be added as a patch and when the config.xml is updated nothing will fail
- If a new instance of an iologik is being placed on an instrument that is not a 1242, if recalled it is worth adding that macro to use the less generic channel names

## How to Test
_verbose instructions for reviewer to test changes
(**Add before making a PR**)_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.