ISISComputingGroup / ISISComputingGroup/IBEX
SANS2D: Motion Setpoints Tolerance Set Through Macro System Test
- Dominant language
- No language data
- Stars
- 6
- Forks
- 2
- Avg merge
- 16h 40m
- Merged PRs (30d)
- 2
Description
As a: Developer
I would like to create a system test to test the motion setpoints tolerance is set to the underlying driver when passed in through a macro to try and prevent problems such as the one which occurred in [#7045](https://github.com/ISISComputingGroup/IBEX/issues/7045) from happening again.
When writing the system test, you could refer to `def test_GIVEN_XD_WHEN_move_motor_THEN_tolerance_checked(self, _, axis_num):` which can be found [HERE](https://github.dev/ISISComputingGroup/EPICS-IOC_Test_Framework/blob/master/tests/motion_setpoints.py) in `EPICS-IOC_Test_Framework\EPICS-IOC_Test_Framework\tests\motion_setpoints.py`
To test a failure of the newly created system test, try reapplying changes made [HERE](https://github.com/ISISComputingGroup/EPICS-motionSetPoints/pull/23/files) to resolve the problem where the constructer overrides value set in db.
### Acceptance Criteria
_What is the acceptance criteria?_
- [ ] A new system test exists and successfully tests the setting of the setpoint to the driver when passed through a macro.
### Extra Information
_Why it is needed?_
Having a system test to check this should aid in reducing support issues of this nature going forward.
Putting such a system test in place would be nice to have given passing the setpoint to the db through a macro is a common use case.
_Where required files/links are_
- Hot-Fix location `motionSetPointsApp/src/motionSetPoints.cpp` implemented as part of: [#23](https://github.com/ISISComputingGroup/EPICS-motionSetPoints/pull/23/files)
- System Tests: `EPICS-IOC_Test_Framework\EPICS-IOC_Test_Framework\tests\motion_setpoints.py` [motion_setpoints.py](https://github.dev/ISISComputingGroup/EPICS-motionSetPoints/blob/master/motionSetPointsApp/src/motionSetPoints.cpp)
## How to Test
_verbose instructions for reviewer to test changes
(**Add before making a PR**)_
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.