ISISComputingGroup / ISISComputingGroup/IBEX

Instrument Scripts: Expand the machines which are checked

Open
#6,921 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

As a developer, I would like to know when the instrument scripts are out of date. A script was added in https://github.com/ISISComputingGroup/IBEX/issues/5907 and then subsequently a Jenkins job and method to check automatically was created in https://github.com/ISISComputingGroup/IBEX/issues/6160 but this only checks MAPS. We need to expand the the number of machines that are checked by doing:

- Add InstScripts$ share to other instruments
- Command to do this can be found in shares\ISIS_Experiment_Controls\command_to_add_instscripts_share.txt
- Reenable the hosts to check by changing host_names at https://github.com/ISISComputingGroup/InstrumentChecker/blob/master/scripts_checker.py#L47

## Acceptance criteria:

- [ ] All scripts using instrument scripts are having their scripts checked automatically in the Jenkins job

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.