ISISComputingGroup / ISISComputingGroup/IBEX

Script Generator: Remove sgp file

Open
#6,845 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

As a user I am confused by having two files associated with the script generator. In a discussion between @JamesKingWork and I (from https://github.com/ISISComputingGroup/IBEX/issues/6670) we decided that the confusion over the multiple files is a significantly larger barrier to users than the problems it solves. We also decided that the JSON should be stored in plain text JSON in the generated file and runscript will load the values from here.

### Acceptance Criteria
* The parameters are written to the `value` variable in generated files in plain text JSON
* `runscript` uses this JSON to get the parameters to load
* The GUI loads parameters from generated scripts by looking at the value field and extracting the json
* The sgp file is removed

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.