ISISComputingGroup / ISISComputingGroup/IBEX

Galil: Redefines positions if sent move on IOC start up

Open
#6,441 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

As an instrument scientist I would like an IOC start up to not affect motion in any way. On LARMOR it was seen that when a move was sent to the IOC on start up due to https://github.com/ISISComputingGroup/IBEX/issues/6423 the IOC redefined the position on the motor to somewhere it was not (~10:15 in the attached log and graph). This was likely a combination of the Galil always redefining positions on start up (normally not an issue as it defines to it's current position) and the move being sent at just the wrong time.

[GALIL_05-20210421.log](https://github.com/ISISComputingGroup/IBEX/files/6357659/GALIL_05-20210421.log)

![Larmor axis issue](https://user-images.githubusercontent.com/10086797/115702696-230ad600-a361-11eb-990f-e28c2f9be315.png)

## Acceptance Criteria
* The IOC does not redefine to the wrong position on start up. If we can't fix the race condition then just remove the redefining of position at all
* There is a test for this

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.