ISISComputingGroup / ISISComputingGroup/IBEX

MARI: Set up sample changer with new homing mode

Open
#6,354 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

As of https://github.com/ISISComputingGroup/IBEX/issues/5729 the mclennan has the homing mode required for the MARI rotating sample changer. We should do the following to set MARI up to use this.

## Acceptance Criteria
* There are two configs for the different sample changer types
* The direction is set into the config such that positive moves in both turn the device in the correct direction
* The homing routine is set so that both move in the correct direction when homed
* The offset is set in the configuration rather than the script
* Test this on the hardware with Duc's script
* Duc's script moves 89.4 degrees for each sample rather than 90 to correct for an inaccurate motor resolution. Correct this and confirm that after a large number of moves the sample changer is still moving accurately (see `NDXMARI/c$/scripts/test_sample_changer.py` to help with this

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.