ISISComputingGroup / ISISComputingGroup/IBEX

BUG: Setting values with CSS spinners when using HOPR and LOPR fails

Open
#5,524 0 comments 0 reactions 0 assignees View on GitHub
bug training
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

A bug noticed when writing the SANS2D vacuum tank OPI. When using spinners the property "Limits from PV" is automatically ticked. This uses the HOPR and LOPR. Sometimes these limits aren't set correctly and they are only for display. CSS will ignore you setpoint and send first 0 to the setpoint and then the original value. Depending on how your motor is set up, this may drive to zero and then back as HOPR and LOPR are only for display. We do not wish to go down into csstudio code to fix this, but a solution is to uncheck the "Limits from PV" on the spinner.

This ticket is to create an OPI check that finds spinners and unchecks that property.

Acceptance criteria:

- [ ] When I commit an OPI with a spinner that has "Limits from PV" checked the commit hook catches and changes this
- [ ] The person committing is notified
- [ ] When I commit an OPI with a spinner that has "Limits from PV" unchecked the commit hook does not catch this

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.