ISISComputingGroup / ISISComputingGroup/IBEX

genie_python: check set_pv and completion callbacks

Open
#4,743 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

set_pv_value() currently uses pend_io() when waiting for a completion callback. I think it should just need a flush_io() after the initial write and then just wait for the event to be signalled, but the code comments suggest otherwise. My only concern with pend_io() is that it also waits for outstanding get and pv search requests to finish, I don't know if this means that in a multi-threaded application your put + callback may get slightly delayed returning if a get or search happened to be being conducted by another thread at the same time.

* we need to write some tests that set pv and check values being progressed
* The confirm flush_io() behaviour

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.