ISISComputingGroup / ISISComputingGroup/IBEX

Blockserver: Ensure test_active_config_holder uses IOC objects in the same way that the real code does

Open
#4,317 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

As a developer I would like my tests to be testing the code as it is actually run in production. In the test_active_config_holder.py tests IOC objects are created to be added to the config. It looks like the real code uses dictionaries instead of these objects.

Acceptance Criteria:
* In ioc.py remove get and __getitem__ (note that these aren't used in the real codebase)
* Running the active config tests should still pass

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.