ISISComputingGroup / ISISComputingGroup/IBEX

Genie_python: Refactor the way exceptions are used

Open
#2,106 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
Avg merge
16h 40m
Merged PRs (30d)
2

Description

As a developer, I don't want generic exception handling to obscure genuine problems.

Currently genie_python uses a lot of `catch Exception as e:`, `catch:`, `raise Exception()` constructs. This is bad because we currently catch things like `MemoryError` (which is obviously not something we can just log and ignore).

Go through the various genie_python files and replace `catch Exception` / `raise Exception` blocks with specific exceptions that we can handle.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.