ISA-tools / ISA-tools/isa-api

implement a guard in material.py

Open
#543 0 comments 0 reactions 1 assignee View on GitHub

@proccaserra is already working on this.

Since Feb 23, 2024.

enhancement
Dominant language
Python
Stars
48
Forks
42
PR merge metrics
No merged PRs in 30d

Description

I'm curious about what we happen if we were to provide the characteristic_data["value"] has a not acceptable data type (list, tuples, set, object, ....).
I think it would append an empty characteristic to the material. Thus, a guard could force a return statement in case of a not acceptable type.

line 92 in material.py

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.