ISA-tools / ISA-tools/isa-api

Labeled Extract silently dropped from ISA JSON serialization if Label not declared

Open
#513 0 comments 0 reactions 1 assignee View on GitHub

@proccaserra is already working on this.

Since Nov 10, 2023.

bug
Dominant language
Python
Stars
48
Forks
42
PR merge metrics
No merged PRs in 30d

Description

  • raise an error at object creation -> do not allow creation of a Labeled Extract if Label not set or set with empty string as a value.
  • create new tests

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.