IRL2 / IRL2/nanover-server-py

Seperate concerns of loading simulations, running dynamics, publishing frames, listing simulations in omni

Open
#422 0 comments 0 reactions 0 assignees View on GitHub
tech debt
Dominant language
Jupyter Notebook
Stars
3
Forks
4
Avg merge
8h 48m
Merged PRs (30d)
37

Description

> Right now Simulation represents both the necessary state of a loaded simulation, and the stub of a simulation that could potentially be loaded from a file for the sake of the Omni runner--these should be two independent things. Doing this would remove the need to assert that certain state is not None (anything that would be loaded later from the file).

Contributor guide

Open the contributing guide

Research direction

Start by locating the Simulation implementation and the Omni runner, then trace how loading, dynamics, frame publishing, and simulation listing currently share that object. Identify the state that belongs to a loaded simulation versus a loadable stub; done means those responsibilities are independent and no longer require assertions for state loaded later.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.