Fix/Clean SPI module builds
Open
@poikilotherm is already working on this.
Since Aug 18, 2023.
Component: Code Infrastructure
Feature: None
Original size: 30
Type: Bug
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 564
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 29
Description
In the CI logs, when building the SPI module, you can find these warnings:
Warning: Some problems were encountered while building the effective model for io.gdcc:dataverse-spi:jar:2.0.0
Warning: 'version' contains an expression but should be a constant. @ io.gdcc:dataverse-spi:2.0.0${project.version.suffix}, /home/runner/work/dataverse/dataverse/modules/dataverse-spi/pom.xml, line 16, column 14
Warning: 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-deploy-plugin is missing. @ io.gdcc:dataverse-spi:2.0.0${project.version.suffix}, /home/runner/work/dataverse/dataverse/modules/dataverse-spi/pom.xml, line 158, column 21
Warning:
Warning: It is highly recommended to fix these problems because they threaten the stability of your build.
Warning:
Warning: For this reason, future Maven versions might no longer support building such malformed projects.
We should address those to ensure nothing breaks.
The first one should be fixed by using sth. like mvn version:set -DnewVersion=.... Probably needs a little scripting.
The second one simply requires adding the plugin to <build><pluginManagement> in dataverse-parent.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.