OptimisticLockException, possibly with several browser tabs open

Issue created by the "entrepot.recherche.data.gouv.fr" team

What steps does it take to reproduce the issue?

The problem is difficult to reproduce

It is possible that during a publication / submission of a dataset, if a user has several browser tabs open on the same dataset (with expired sessions), the error is generated

• When does this issue occur?

When publishing / submitting a dataset

• Which page(s) does it occurs on?

View of a dataset

• What happens?

We have observed this error when updating a Dataset in the database, for example:

https://github.com/IQSS/dataverse/blob/1a797171cdb73741b5da4a683f38697558349b5c/src/main/java/edu/harvard/iq/dataverse/engine/command/impl/SubmitDatasetForReviewCommand.java#L52-L60

Or

https://github.com/IQSS/dataverse/blob/1a797171cdb73741b5da4a683f38697558349b5c/src/main/java/edu/harvard/iq/dataverse/engine/command/impl/PublishDatasetCommand.java#L175

We think this can create a problem in some cases.
For example when submitting for review, in summary, it goes like this:

-> DatasetLock "InReview" on dataset
-> Updated modification dates
-> Dataset merge
-> Send notifications to users

The problem is that in case of an "OptimisticLockException" type error, the merge is KO (dates not modified and notifications not sent) while the DatasetLock is created.

Example of Java stack trace is attached.

• To whom does it occur (all users, curators, superusers)?

connected users

• What did you expect to happen?

A handling of the "OptimisticLockException" error in the Java code in order to improve the user experience

Which version of Dataverse are you using?

5.12.1

Any related open or closed issues to this bug report?

https://groups.google.com/g/dataverse-community/c/5usS5yqMjqI

Start by reading SubmitDatasetForReviewCommand.java at lines 52-60 and PublishDatasetCommand.java at line 175, then trace the dataset lock, date update, merge, and notification sequence described in the issue. Investigate how an OptimisticLockException affects that sequence when several tabs use expired sessions. Done means the failure is handled consistently without leaving the dataset lock or user-facing workflow in a misleading state.