IQSS / IQSS/dataverse

Html "\"" in TOU breaks SchemaDotOrg export; and causes a 500 in dataset page.

Open
#8,224 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.1k
Forks
564
Avg merge
2d 2h
Merged PRs (30d)
29

Description

There are 2 issues in one:

  1. (simple, but important) The method getJsonLd() in DatasetPage.java needs to catch an exception from the export, as to NOT kill the page with a 500 when it fails, for whatever reason.
  2. The specific issue of an html entity " resulting in a failure to export and cache the jsonLd/SchemaDotOrg format. (Will add the details in the next comment, to keep the description compact).

To reproduce - screenshot from @pdurbin:

Screen Shot 2021-11-08 at 11 55 31 AM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in DatasetPage.java at getJsonLd() and reproduce the failure using a dataset containing the quoted HTML entity shown in the issue. Trace the SchemaDotOrg export and cache path, then ensure an export exception does not turn the dataset page into a 500 and that this input no longer breaks the JSON-LD export.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.